-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.58] instancetype: Ignore unexpected existing CRs during restore #8912
[release-0.58] instancetype: Ignore unexpected existing CRs during restore #8912
Conversation
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
5cc62c0 failed to accommodate repeat attempts to reconcile a VirtualMachineRestore that in turn lead to multiple calls to restoreInstancetypeControllerRevision being made for the same ControllerRevision. This change handles this case by ignoring any existing ControllerRevisions found during the restore, assuming that the existing ControllerRevision was created by a previous call to restoreInstancetypeControllerRevision. Future changes will check the contents of this ControllerRevision against that of the VirtualMachineSnapshot to ensure they match. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
/lgtm |
/cc @mhenriks |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest-required |
This is an automated cherry-pick of #8891
/assign lyarwood