[release-0.58] instancetype: Ignore unexpected existing CRs during restore #8912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
5cc62c0 failed to accommodate repeat attempts to reconcile a VirtualMachineRestore that in turn lead to multiple calls to restoreInstancetypeControllerRevision being made for the same ControllerRevision. This change handles this case by ignoring any existing ControllerRevisions found during the restore, assuming that the existing ControllerRevision was created by a previous call to restoreInstancetypeControllerRevision. Future changes will check the contents of this ControllerRevision against that of the VirtualMachineSnapshot to ensure they match. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
kubevirt-bot
added
release-note-none
|
/lgtm |
|
/cc @mhenriks |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest-required |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8891
/assign lyarwood