Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.58] Fix addvolume removevolume bugs #9230

Merged
merged 4 commits into from
Feb 16, 2023
Merged

[release-0.58] Fix addvolume removevolume bugs #9230

merged 4 commits into from
Feb 16, 2023

Conversation

ShellyKa13
Copy link
Contributor

@ShellyKa13 ShellyKa13 commented Feb 13, 2023 •
edited

What this PR does / why we need it:
This is a manual backport of #9133

Release note:

Fix addvolume not rejecting adding existing volume source, fix removevolume allowing to remove non hotpluggable volume

@ShellyKa13
Fix add/remove volume bugs
27ed337 
* Fix bug of allowing to add existing volume pvc/dv
with another volume name: the code checked for volume.Name
instead of checking the dv/pvc name.
* Fix bug of allowing to remove existing volume which wasnt
hotplugged.
* Add the check of add and remove volume to persistent add/remove
volume code path - in case of add/remove to VM the checks should also
happen.
* Add and fix current UT accordingly.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
@ShellyKa13
Add negative functional test to verify bug fix
72fc7e7 
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@ShellyKa13
Adress review and failing tests
df9ec82 
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Feb 13, 2023
@ShellyKa13 ShellyKa13 changed the title [release-0.58] Fix hotplug bugs 0.58 [release-0.58] Fix addvolume removevolume bugs Feb 13, 2023
@ShellyKa13
Copy link
Contributor Author

/hold
should be merged once backport to 0.59 is merged: #9197

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2023
@ShellyKa13
Adjustments to match backport version
a3bb518 
Signed-off-by: Shelly Kagan <skagan@redhat.com>
@ShellyKa13
Copy link
Contributor Author

/retest

@ShellyKa13
Copy link
Contributor Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2023
@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Feb 15, 2023 •
edited

@ShellyKa13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-goveralls a3bb518 link false /test pull-kubevirt-goveralls-0.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 18f8d81 into kubevirt:release-0.58 Feb 16, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

Assignees

@mhenriks mhenriks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ShellyKa13 @mhenriks @kubevirt-bot @kubevirt-commenter-bot