Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update Docs for Docker Authentication in Mac #9344

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

humblenginr
Copy link
Contributor

@humblenginr humblenginr commented Mar 1, 2023

What this PR does / why we need it:

Since Bazel does not support OSX keychain, the current documentation asks mac users to deactivate the Securely store Docker logins in macOS keychain option in Docker Desktop's preferences. This is misleading since the option is no longer present in the Docker Desktop's preferences.

Screenshot 2023-03-01 at 10 37 27 PM

There are some nuances with the way docker handles authentication and credential helpers. This PR captures my learnings and updates the docs to be in sync with the way the system behaves now.

In order to make docker store the credentials in the config.json file (so that Bazel can make use of it), we have to disable all the credential helpers. There appears to be no way to generally disable the credential helpers for all registries. But there is a way to do this on a registry-to-registry basis, which is what the updated documentation suggests we do.

Special notes for your reviewer:
References:

  1. Stack Overflow - https://stackoverflow.com/a/69730718/21174500
  2. Github Issue - ~/.docker/config.json reverts to default settings after a Docker Desktop restart docker/for-mac#6295

Release note:

None

Signed-off-by: Nithish <nithishkarthik01@gmail.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 1, 2023
@kubevirt-bot
Copy link
Contributor

Hi @sudo-NithishKarthik. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Nithish <nithishkarthik01@gmail.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 1, 2023
@usrbinkat
Copy link

/cc @usrbinkat

Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@brianmcarey
Copy link
Member

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2023
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Mar 10, 2023

@sudo-NithishKarthik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-fossa 9f36837 link false /test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants