-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update Docs for Docker Authentication in Mac #9344
[Docs] Update Docs for Docker Authentication in Mac #9344
Conversation
Signed-off-by: Nithish <nithishkarthik01@gmail.com>
Hi @sudo-NithishKarthik. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Nithish <nithishkarthik01@gmail.com>
/cc @usrbinkat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@sudo-NithishKarthik: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
What this PR does / why we need it:
Since Bazel does not support OSX keychain, the current documentation asks mac users to deactivate the
Securely store Docker logins in macOS keychain
option in Docker Desktop's preferences. This is misleading since the option is no longer present in the Docker Desktop's preferences.There are some nuances with the way docker handles authentication and credential helpers. This PR captures my learnings and updates the docs to be in sync with the way the system behaves now.
In order to make docker store the credentials in the config.json file (so that Bazel can make use of it), we have to disable all the credential helpers. There appears to be no way to generally disable the credential helpers for all registries. But there is a way to do this on a registry-to-registry basis, which is what the updated documentation suggests we do.
Special notes for your reviewer:
References:
~/.docker/config.json
reverts to default settings after a Docker Desktop restart docker/for-mac#6295Release note: