Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nithish Karthik as a Community Member #2925

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

humblenginr
Copy link
Contributor

@humblenginr humblenginr commented Aug 9, 2023

GitHub Username

@humblenginr

Requirements

[x] I have reviewed the community code of conduct (https://github.com/kubevirt/kubevirt/blob/master/CODE_OF_CONDUCT.md)

[x] I have enabled 2FA on my GitHub account (https://github.com/settings/security)

[x] I have subscribed to the kubevirt-dev e-mail list (https://groups.google.com/forum/#!forum/kubevirt-dev)

[x] I am actively contributing to KubeVirt

[x] I have two sponsors that meet the sponsor requirements listed in the community membership guidelines

[x] I have spoken to my sponsors ahead of this application and they have agreed to sponsor my application

[x] I have publicly introduced myself to the community through one of the community communication channels

(https://github.com/kubevirt/community#socializing)

Sponsors

List of contributions to the KubeVirt project

  • PRs reviewed and/or authored
  • Issues responded to

Signed-off-by: Nithish <nithishkarthik01@gmail.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 9, 2023
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2023
@kubevirt-bot
Copy link
Contributor

Hi @sudo-NithishKarthik. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Nithish <nithishkarthik01@gmail.com>
@alicefr
Copy link
Member

alicefr commented Aug 9, 2023

/ok-to-test
/approve
/lgtm
/hold

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Aug 9, 2023
@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2023
@alicefr
Copy link
Member

alicefr commented Aug 9, 2023

Put hold to allow other to review this
/cc @aburdenthehand @dhiller @xpivarc

@alicefr
Copy link
Member

alicefr commented Aug 9, 2023

@sudo-NithishKarthik is participating in the GSoc program for generating the seccomp profile at runtime, he meets regularly with @xpivarc and me, and his work will be published under https://github.com/kubevirt/k8s-seccomp-generator

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alicefr, dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@xpivarc
Copy link
Member

xpivarc commented Aug 10, 2023

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@kubevirt-bot kubevirt-bot merged commit 24765e1 into kubevirt:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants