Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.59] [e2e-tests]Should remove and restore labeler only from workers #9347

Merged
merged 1 commit into from
Mar 3, 2023
Merged

[release-0.59] [e2e-tests]Should remove and restore labeler only from workers #9347

merged 1 commit into from
Mar 3, 2023

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #9215

/assign fossedihelm

NONE

Should remove and restore labeller only from workers Currently in som…
af699e6 
…e tests we are waiting for the node labeller to be resumed in any nodes including unschedulable nodes and that will not work because master shouldn't be labeled by node labeller.

Signed-off-by: bmordeha <bmodeha@redhat.com>
@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 2, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Mar 2, 2023
Merged
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Mar 2, 2023
@Barakmor1
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@acardace
Copy link
Member

acardace commented Mar 2, 2023

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acardace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fossedihelm
Copy link
Contributor

/retest-required

@kubevirt-bot
Copy link
Contributor Author

kubevirt-bot commented Mar 3, 2023 •
edited
Loading

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-arm64 af699e6 link false /test pull-kubevirt-e2e-arm64-0.59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fossedihelm
Copy link
Contributor

/retest-required

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit bca9605 into kubevirt:release-0.59 Mar 3, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbidarkar kbidarkar Awaiting requested review from kbidarkar

@marceloamaral marceloamaral Awaiting requested review from marceloamaral

Assignees

@fossedihelm fossedihelm

@Barakmor1 Barakmor1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kubevirt-bot @Barakmor1 @acardace @kubevirt-commenter-bot @fossedihelm