Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e-tests]Should remove and restore labeler only from workers #9215

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

Barakmor1
Copy link
Member

@Barakmor1 Barakmor1 commented Feb 12, 2023

Currently in some tests we are waiting for
the node labeller to be resumed in any nodes
including unschedulable nodes and that will not work
because master shouldn't be labeled by node
labeller.

Signed-off-by: bmordeha bmodeha@redhat.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 12, 2023
@kubevirt-bot kubevirt-bot added size/S release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 12, 2023
@iholder101
Copy link
Contributor

/lgtm
Great stuff @Barakmor1! Thanks for the fix!

Tiny nit, in the PR description you write: including master nodes and that will not work because master shouldn't be labeled by node labeller. Can you replace master nodes with unschedulable nodes to align with the actual code?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2023
Currently in some tests we are waiting for
the node labeller to be resumed in any nodes
including unschedulable nodes and that will not work
because master shouldn't be labeled by node
labeller.

Signed-off-by: bmordeha <bmodeha@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2023
@Barakmor1
Copy link
Member Author

@iholder101 Done

@iholder101
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2023
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Feb 12, 2023

@Barakmor1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-fossa 39a8d48 link false /test pull-kubevirt-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2023
@kubevirt-bot kubevirt-bot merged commit f55b727 into kubevirt:main Feb 12, 2023
@Barakmor1
Copy link
Member Author

/cherrypick release-0.58

@Barakmor1
Copy link
Member Author

/cherrypick release-0.53

@kubevirt-bot
Copy link
Contributor

@Barakmor1: new pull request created: #9274

In response to this:

/cherrypick release-0.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

@Barakmor1: #9215 failed to apply on top of branch "release-0.53":

Applying: Should remove and restore labeller only from workers Currently in some tests we are waiting for the node labeller to be resumed in any nodes including unschedulable nodes and that will not work because master shouldn't be labeled by node labeller.
Using index info to reconstruct a base tree...
M	tests/hyperv_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/hyperv_test.go
CONFLICT (content): Merge conflict in tests/hyperv_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Should remove and restore labeller only from workers Currently in some tests we are waiting for the node labeller to be resumed in any nodes including unschedulable nodes and that will not work because master shouldn't be labeled by node labeller.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fossedihelm
Copy link
Contributor

/cherrypick release-0.59

@kubevirt-bot
Copy link
Contributor

@fossedihelm: new pull request created: #9347

In response to this:

/cherrypick release-0.59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants