Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubevirt-top-consumers dashboard #237

Merged
merged 1 commit into from
May 2, 2024

Conversation

sradco
Copy link
Collaborator

@sradco sradco commented May 1, 2024

Update kubevirt-top-consumers dashboard.
Replace:
kubevirt_vmi_vcpu_wait_seconds -> kubevirt_vmi_vcpu_wait_seconds_total kubevirt_vmi_memory_swap_in_traffic_bytes_total -> kubevirt_vmi_memory_swap_in_traffic_bytes

Since the vCPU Wait by Virtual Machines and Memory Swap Traffic by Virtual Machines graphs are also empty on CNV engineering due to the changes in: kubevirt/kubevirt#9821

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://issues.redhat.com/browse/OCPBUGS-33077

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

Update kubevirt-top-consumers dashboard.
Replace:
kubevirt_vmi_vcpu_wait_seconds -> kubevirt_vmi_vcpu_wait_seconds_total
kubevirt_vmi_memory_swap_in_traffic_bytes_total -> kubevirt_vmi_memory_swap_in_traffic_bytes

Since the vCPU Wait by Virtual Machines and Memory Swap Traffic by Virtual Machines graphs are also empty on CNV engineering due to the changes in: kubevirt/kubevirt#9821

Signed-off-by: Shirly Radco <sradco@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels May 1, 2024
@sradco sradco changed the title Update kubevirt-top-consumers.json Update kubevirt-top-consumers dashboard May 1, 2024
@assafad
Copy link
Collaborator

assafad commented May 1, 2024

/lgtm

@sradco sradco requested a review from assafad May 2, 2024 07:03
@sradco sradco merged commit 4f6aa57 into main May 2, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request May 2, 2024
…t_top_consumers_dashboard

Update kubevirt-top-consumers dashboard
@kubevirt-bot kubevirt-bot mentioned this pull request May 2, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants