Add periodics and presubmits for k8s-1.21 #1192

dhiller · 2021-05-03T12:27:15Z

Presubmits are reporting to GitHub but need to get triggered manually.

FYI @EdDev

/cc @rmohr @fgimenez @qinqon

dhiller · 2021-05-03T12:34:21Z

FYI @enp0s3

dhiller · 2021-05-03T13:26:02Z

/retest

qinqon · 2021-05-04T05:44:12Z

@dhiller for 1.20 we splitted it into sigs, let's do the same for 1.21.

EdDev

Thanks! Looks good to me, only two nits inline.

EdDev · 2021-05-04T08:36:16Z

github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

@@ -284,7 +525,7 @@ presubmits:
          resources:
            requests:
              memory: "34Gi"
-  
+


Unrelated change

So you are saying I should move the removal of trailing whitespaces to a new PR?

No :)
I am not clear what triggered this... is it your editor?

Yes, IntelliJ has a switch that automatically removes trailing whitespace.

EdDev · 2021-05-04T08:36:23Z

github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

@@ -674,7 +915,7 @@ presubmits:
          hostPath:
            path: /dev/vfio/
            type: Directory
-  
+


Unrelated change

EdDev

Thank you!

qinqon · 2021-05-04T13:03:37Z

/reharse

Does this work with new jobs ?

qinqon · 2021-05-04T13:03:42Z

/rehearse

qinqon · 2021-05-04T13:05:01Z

/hold

Let's wait for rehearse

qinqon · 2021-05-04T13:05:53Z

Looks like 1.21-cgroupsv2 is broken

 [[ k8s-1.21-cgroupsv2 =~ sig-compute ]]
+ export KUBEVIRT_PROVIDER=k8s-1.21-cgroupsv2
+ KUBEVIRT_PROVIDER=k8s-1.21-cgroupsv2
+ '[' '!' -d cluster-up/cluster/k8s-1.21-cgroupsv2 ']'
+ echo 'The cluster provider k8s-1.21-cgroupsv2 does not exist'
The cluster provider k8s-1.21-cgroupsv2 does not exist
+ exit 1
+ EXIT_VALUE=1
+ se

dhiller · 2021-05-04T13:27:03Z

Looks like 1.21-cgroupsv2 is broken

 [[ k8s-1.21-cgroupsv2 =~ sig-compute ]]
+ export KUBEVIRT_PROVIDER=k8s-1.21-cgroupsv2
+ KUBEVIRT_PROVIDER=k8s-1.21-cgroupsv2
+ '[' '!' -d cluster-up/cluster/k8s-1.21-cgroupsv2 ']'
+ echo 'The cluster provider k8s-1.21-cgroupsv2 does not exist'
The cluster provider k8s-1.21-cgroupsv2 does not exist
+ exit 1
+ EXIT_VALUE=1
+ se

@qinqon I figure someone (TM) first needs to provide these on the kubevirt/kubevirt side. I didn't yet get to this.

dhiller · 2021-05-04T14:35:15Z

Looks like 1.21-cgroupsv2 is broken
 [[ k8s-1.21-cgroupsv2 =~ sig-compute ]]
+ export KUBEVIRT_PROVIDER=k8s-1.21-cgroupsv2
+ KUBEVIRT_PROVIDER=k8s-1.21-cgroupsv2
+ '[' '!' -d cluster-up/cluster/k8s-1.21-cgroupsv2 ']'
+ echo 'The cluster provider k8s-1.21-cgroupsv2 does not exist'
The cluster provider k8s-1.21-cgroupsv2 does not exist
+ exit 1
+ EXIT_VALUE=1
+ se
@qinqon I figure someone (TM) first needs to provide these on the kubevirt/kubevirt side. I didn't yet get to this.

@qinqon now I get it. The cgroupsv2 is a separate provider that needs to get added to the kubevirtci. So maybe it's best to remove the cgroupsv2 at first and add it after it was created on kubevirtci. Makes sense?

qinqon · 2021-05-04T14:38:36Z

Looks like 1.21-cgroupsv2 is broken
 [[ k8s-1.21-cgroupsv2 =~ sig-compute ]]
+ export KUBEVIRT_PROVIDER=k8s-1.21-cgroupsv2
+ KUBEVIRT_PROVIDER=k8s-1.21-cgroupsv2
+ '[' '!' -d cluster-up/cluster/k8s-1.21-cgroupsv2 ']'
+ echo 'The cluster provider k8s-1.21-cgroupsv2 does not exist'
The cluster provider k8s-1.21-cgroupsv2 does not exist
+ exit 1
+ EXIT_VALUE=1
+ se
@qinqon I figure someone (TM) first needs to provide these on the kubevirt/kubevirt side. I didn't yet get to this.
@qinqon now I get it. The cgroupsv2 is a separate provider that needs to get added to the kubevirtci. So maybe it's best to remove the cgroupsv2 at first and add it after it was created on kubevirtci. Makes sense?

Clearly it does not make sense to have a job we cannot "exercise", let's remove those.

qinqon · 2021-05-04T14:39:54Z

humm and this ?

time="2021-05-04T14:21:30Z" level=info msg="Using remote image quay.io/kubevirtci/k8s-1.21:2104301741-c950058"
14:21:30: 2021/05/04 14:21:30 failed to download quay.io/kubevirtci/k8s-1.21:2104301741-c950058: Error response from daemon: unauthorized: access to the requested resource is not authorized
14:21:32: 2021/05/04 14:21:32 failed to download quay.io/kubevirtci/k8s-1.21:2104301741-c950058: Error response from daemon: unauthorized: access to the requested resource is not authorized
14:21:34: 2021/05/04 14:21:34 failed to download quay.io/kubevirtci/k8s-1.21:2104301741-c950058: Error response from daemon: unauthorized: access to the requested resource is not authorized
14:21:41: 2021/05/04 14:21:41 failed to download quay.io/kubevirtci/k8s-1.21:2104301741-c950058: Error response from daemon: unauthorized: access to the requested resource is not authorized

Maybe we need to change something at rehearsal to use the proper QUAY auth ?

dhiller · 2021-05-04T14:42:14Z

humm and this ?

time="2021-05-04T14:21:30Z" level=info msg="Using remote image quay.io/kubevirtci/k8s-1.21:2104301741-c950058"
14:21:30: 2021/05/04 14:21:30 failed to download quay.io/kubevirtci/k8s-1.21:2104301741-c950058: Error response from daemon: unauthorized: access to the requested resource is not authorized
14:21:32: 2021/05/04 14:21:32 failed to download quay.io/kubevirtci/k8s-1.21:2104301741-c950058: Error response from daemon: unauthorized: access to the requested resource is not authorized
14:21:34: 2021/05/04 14:21:34 failed to download quay.io/kubevirtci/k8s-1.21:2104301741-c950058: Error response from daemon: unauthorized: access to the requested resource is not authorized
14:21:41: 2021/05/04 14:21:41 failed to download quay.io/kubevirtci/k8s-1.21:2104301741-c950058: Error response from daemon: unauthorized: access to the requested resource is not authorized

Maybe we need to change something at rehearsal to use the proper QUAY auth ?

IMHO this should just work, otherwise it does not make sense to have a rehearsal of a job. Maybe there's sth wrong with the container proxy settings. Will have a look.

Presubmits are reporting to GitHub but need to get triggered manually. Signed-off-by: Daniel Hiller <dhiller@redhat.com>

dhiller · 2021-05-04T14:51:12Z

/rehearse

dhiller · 2021-05-05T08:17:35Z

/rehearse

dhiller · 2021-05-05T08:18:31Z

/retest

fgimenez · 2021-05-05T13:04:11Z

github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml

+        resources:
+          requests:
+            memory: "34Gi"
+- name: periodic-kubevirt-e2e-k8s-1.21


I think we no longer need a provider lane, it would be empty as soon as all the tests are properly tagged (only 8 are left).

fgimenez · 2021-05-05T13:04:30Z

github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

@@ -1,5 +1,209 @@
 presubmits:
  kubevirt/kubevirt:
+  - name: pull-kubevirt-e2e-k8s-1.21


Same as above, we don't need a provider presubmit.

fgimenez · 2021-05-05T13:06:20Z

github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml

+          - name: TARGET
+            value: "k8s-1.21"
+          - name: KUBEVIRT_E2E_FOCUS
+            value: "Operator"


All the references to Operator should be changed to [sig-operator] now that kubevirt/kubevirt#5534 has landed.

This Operator string is still here, once it is changed good to go.

Suggested change

value: "Operator"

value: "[sig-operator]"

Dang, sorry for that 😕

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>

dhiller · 2021-05-05T14:45:37Z

/rehearse

dhiller · 2021-05-05T14:46:20Z

@fgimenez thanks for the review, fixed the issues. PTAL!

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>

dhiller · 2021-05-05T15:07:45Z

/rehearse

fgimenez · 2021-05-05T15:12:52Z

github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml

+          - name: TARGET
+            value: "k8s-1.21"
+          - name: KUBEVIRT_E2E_FOCUS
+            value: "[sig-operator]"


Sorry that I didn't notice before but we are missing escapes for the square brackets like here https://github.com/kubevirt/kubevirt/blob/master/automation/test.sh#L308

Suggested change

value: "[sig-operator]"

value: "\\[sig-operator\\]"

fgimenez · 2021-05-05T15:13:38Z

github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

+            - name: TARGET
+              value: k8s-1.21
+            - name: KUBEVIRT_E2E_FOCUS
+              value: "[sig-operator]"


Suggested change

value: "[sig-operator]"

value: "\\[sig-operator\\]"

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>

dhiller · 2021-05-06T08:19:57Z

/rehearse

fgimenez

/lgtm
/approve
/hold

Thanks! Feel free to unhold when ready.

kubevirt-bot · 2021-05-06T08:34:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgimenez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/OWNERS~~ [fgimenez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot · 2021-05-06T11:12:20Z

@dhiller: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
rehearsal-pull-kubevirt-e2e-k8s-1.21-cgroupsv2	`340a40e`	link	`/test pull-kubevirt-e2e-k8s-1.21-cgroupsv2`
rehearsal-pull-kubevirt-e2e-k8s-1.21-operator	`05a99bc`	link	`/test pull-kubevirt-e2e-k8s-1.21-operator`
rehearsal-pull-kubevirt-e2e-k8s-1.21-sig-compute	`33f7fcb`	link	`/test pull-kubevirt-e2e-k8s-1.21-sig-compute`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dhiller · 2021-05-06T12:10:38Z

/unhold

dhiller · 2021-05-06T12:14:24Z

/override rehearsal-pull-kubevirt-e2e-k8s-1.21-sig-compute

kubevirt-bot · 2021-05-06T12:14:28Z

@dhiller: Overrode contexts on behalf of dhiller: rehearsal-pull-kubevirt-e2e-k8s-1.21-sig-compute

In response to this:

/override rehearsal-pull-kubevirt-e2e-k8s-1.21-sig-compute

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhiller · 2021-05-06T12:15:07Z

/override rehearsal-pull-kubevirt-e2e-k8s-1.21-operator

kubevirt-bot · 2021-05-06T12:15:12Z

@dhiller: Overrode contexts on behalf of dhiller: rehearsal-pull-kubevirt-e2e-k8s-1.21-operator

In response to this:

/override rehearsal-pull-kubevirt-e2e-k8s-1.21-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot · 2021-05-06T12:33:36Z

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

key kubevirt-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml
key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

In response to this:

Presubmits are reporting to GitHub but need to get triggered manually.

FYI @EdDev

/cc @rmohr @fgimenez @qinqon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot requested review from fgimenez, qinqon and rmohr May 3, 2021 12:27

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels May 3, 2021

dhiller force-pushed the add-jobs-for-1.21 branch from 9925681 to 941045f Compare May 3, 2021 12:36

dhiller force-pushed the add-jobs-for-1.21 branch from 941045f to 340a40e Compare May 4, 2021 08:27

kubevirt-bot added size/L and removed size/M labels May 4, 2021

dhiller changed the title ~~Add periodic and presubmit for k8s-1.21~~ Add periodics and presubmits for k8s-1.21 May 4, 2021

EdDev reviewed May 4, 2021

View reviewed changes

dhiller requested a review from EdDev May 4, 2021 12:48

EdDev approved these changes May 4, 2021

View reviewed changes

kubevirt-bot assigned EdDev May 4, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2021

Add periodics and presubmits for k8s-1.21

dfe5187

Presubmits are reporting to GitHub but need to get triggered manually. Signed-off-by: Daniel Hiller <dhiller@redhat.com>

dhiller force-pushed the add-jobs-for-1.21 branch from 340a40e to dfe5187 Compare May 4, 2021 14:44

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 4, 2021

fgimenez reviewed May 5, 2021

View reviewed changes

Remove plain 1.21 lanes, fix operator focus

46062db

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>

dhiller requested a review from fgimenez May 5, 2021 14:46

Change Operator to [sig-operator]

05a99bc

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>

fgimenez reviewed May 5, 2021

View reviewed changes

Add escaping to square brackets

33f7fcb

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>

fgimenez approved these changes May 6, 2021

View reviewed changes

kubevirt-bot assigned fgimenez May 6, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2021

kubevirt-bot merged commit e545b41 into kubevirt:master May 6, 2021

Add periodics and presubmits for k8s-1.21 #1192

Add periodics and presubmits for k8s-1.21 #1192

Conversation

dhiller commented May 3, 2021 • edited

dhiller commented May 3, 2021

dhiller commented May 3, 2021

qinqon commented May 4, 2021

EdDev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EdDev left a comment

Choose a reason for hiding this comment

qinqon commented May 4, 2021

qinqon commented May 4, 2021

qinqon commented May 4, 2021

qinqon commented May 4, 2021

dhiller commented May 4, 2021

dhiller commented May 4, 2021

qinqon commented May 4, 2021

qinqon commented May 4, 2021 • edited

dhiller commented May 4, 2021

dhiller commented May 4, 2021

dhiller commented May 5, 2021

dhiller commented May 5, 2021

fgimenez May 5, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhiller commented May 5, 2021

dhiller commented May 5, 2021

dhiller commented May 5, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhiller commented May 6, 2021

fgimenez left a comment

Choose a reason for hiding this comment

kubevirt-bot commented May 6, 2021

kubevirt-bot commented May 6, 2021

dhiller commented May 6, 2021

dhiller commented May 6, 2021

kubevirt-bot commented May 6, 2021

dhiller commented May 6, 2021

kubevirt-bot commented May 6, 2021

kubevirt-bot commented May 6, 2021

dhiller commented May 3, 2021 •

edited

qinqon commented May 4, 2021 •

edited

fgimenez May 5, 2021 •

edited