Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirtci, presubmit: Introduce k8s-1.25-ipv6 #2489

Merged
merged 2 commits into from
Nov 28, 2022
Merged

kubevirtci, presubmit: Introduce k8s-1.25-ipv6 #2489

merged 2 commits into from
Nov 28, 2022

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Nov 27, 2022 •
edited
Loading

@oshoval
vm based providers: Clone k8s-1.24-ipv6
e92cc9f 
Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 27, 2022
@oshoval
Copy link
Contributor Author

oshoval commented Nov 27, 2022

/rehearse

@oshoval
Copy link
Contributor Author

oshoval commented Nov 27, 2022 •
edited
Loading 

error: resource mapping not found for name: "calico-kube-controllers" namespace: "kube-system" from "/provision/cni.yaml": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"

need to fix cni_ipv6.diff - done

@oshoval
Copy link
Contributor Author

oshoval commented Nov 27, 2022

/rehearse

1 similar comment
@oshoval
Copy link
Contributor Author

oshoval commented Nov 27, 2022

/rehearse

@oshoval oshoval mentioned this pull request Nov 28, 2022
Merged
@oshoval
kubevirtci, presubmit: Introduce k8s-1.25-ipv6
b78f94c 
Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval
Copy link
Contributor Author

oshoval commented Nov 28, 2022

Addressed comments,
Removed the manual apply of kubevirt/kubevirtci#912

/hold
until kubevirt/kubevirtci#912 is merged

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2022
@oshoval oshoval marked this pull request as ready for review November 28, 2022 11:40
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2022
@oshoval oshoval requested review from dhiller and removed request for vladikr, qinqon and stu-gott November 28, 2022 11:41
dhiller
dhiller approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Since the new lane is triggered manually, you could also merge it right away, but I'll leave that up to you :)

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@oshoval
Copy link
Contributor Author

oshoval commented Nov 28, 2022

Right thanks
lets merge it

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2022
@kubevirt-bot kubevirt-bot merged commit 2fe00c9 into kubevirt:main Nov 28, 2022
@kubevirt-bot
Copy link
Contributor

@oshoval: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirtci-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-presubmits.yaml

In response to this:

Depends on kubevirt/kubevirtci#912

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller dhiller approved these changes

Assignees

@dhiller dhiller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oshoval @kubevirt-bot @dhiller