Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common-instancetypes: Add basic functional test coverage #2582

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

lyarwood
Copy link
Member

This change adds a basic func test prow job for common-instancetypes that deploys KubeVirt from HEAD, deploys common-instancetypes and then exercises the various validation code paths by creating VirtualMachines for each instance type and preference available in the environment.

Future test coverage could start these VirtualMachines and exercise the runtime VirtualMachineInstance code paths but this should be enough for now ahead of KubeVirt v0.59.0 and common-instancetypes v0.1.0 being cut.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 30, 2023
@lyarwood
Copy link
Member Author

/cc @0xFelix

@lyarwood
Copy link
Member Author

/rehearse

@lyarwood
Copy link
Member Author

/hold

Needs kubevirt/common-instancetypes#27

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2023
This change adds a basic func test prow job for common-instancetypes
that deploys KubeVirt from HEAD, deploys common-instancetypes and then
exercises the various validation code paths by creating VirtualMachines
for each instance type and preference available in the environment.

Future test coverage could start these VirtualMachines and exercise the
runtime VirtualMachineInstance code paths but this should be enough for
now ahead of KubeVirt `v0.59.0` and common-instancetypes `v0.1.0` being
cut.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the common-instancetypes-functest branch from c6702d9 to 7ddd6e6 Compare January 30, 2023 14:44
@lyarwood
Copy link
Member Author

/rehearse

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jan 30, 2023

@lyarwood: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rehearsal-pull-common-instancetypes-k8s-1.26-kubevirt-functest c6702d9 link unknown /test pull-common-instancetypes-k8s-1.26-kubevirt-functest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lyarwood
Copy link
Member Author

Excellent, now holding until kubevirt/kubevirt#9103 lands

@0xFelix
Copy link
Member

0xFelix commented Jan 30, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@lyarwood
Copy link
Member Author

lyarwood commented Feb 3, 2023

/rehearse

@lyarwood
Copy link
Member Author

lyarwood commented Feb 3, 2023

/hold cancel

@brianmcarey would you mind giving this a once over from a CI point of view, it's passing now that kubevirt/kubevirt#9103 has landed in KubeVirt. Eventually I'd like to move the job to using the latest images instead of building from source but that's a story for another sprint.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@kubevirt-bot kubevirt-bot merged commit e989312 into kubevirt:main Feb 3, 2023
@kubevirt-bot
Copy link
Contributor

@lyarwood: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key common-instancetypes-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/common-instancetypes-presubmits.yaml

In response to this:

This change adds a basic func test prow job for common-instancetypes that deploys KubeVirt from HEAD, deploys common-instancetypes and then exercises the various validation code paths by creating VirtualMachines for each instance type and preference available in the environment.

Future test coverage could start these VirtualMachines and exercise the runtime VirtualMachineInstance code paths but this should be enough for now ahead of KubeVirt v0.59.0 and common-instancetypes v0.1.0 being cut.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants