-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common-instancetypes: Add basic functional test coverage #2582
common-instancetypes: Add basic functional test coverage #2582
Conversation
/cc @0xFelix |
/rehearse |
/hold |
This change adds a basic func test prow job for common-instancetypes that deploys KubeVirt from HEAD, deploys common-instancetypes and then exercises the various validation code paths by creating VirtualMachines for each instance type and preference available in the environment. Future test coverage could start these VirtualMachines and exercise the runtime VirtualMachineInstance code paths but this should be enough for now ahead of KubeVirt `v0.59.0` and common-instancetypes `v0.1.0` being cut. Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
c6702d9
to
7ddd6e6
Compare
/rehearse |
@lyarwood: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Excellent, now holding until kubevirt/kubevirt#9103 lands |
/lgtm |
/rehearse |
/hold cancel @brianmcarey would you mind giving this a once over from a CI point of view, it's passing now that kubevirt/kubevirt#9103 has landed in KubeVirt. Eventually I'd like to move the job to using the latest images instead of building from source but that's a story for another sprint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lyarwood: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change adds a basic func test prow job for common-instancetypes that deploys KubeVirt from HEAD, deploys common-instancetypes and then exercises the various validation code paths by creating VirtualMachines for each instance type and preference available in the environment.
Future test coverage could start these VirtualMachines and exercise the runtime VirtualMachineInstance code paths but this should be enough for now ahead of KubeVirt
v0.59.0
and common-instancetypesv0.1.0
being cut.