-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance documentation #318
Conversation
Hi @0xFelix. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @lyarwood |
@0xFelix: GitHub didn't allow me to request PR reviews from the following users: geetikakay, lyarwood. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming others are okay with this being in the main README as opposed to a separate contributor or devel doc somewhere?
@lyarwood: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@0xFelix Can you please move info for developers to a separate file? It was ok to keep it in |
Enhance documentation by adding resource type / CRD requirements to README.md and by moving developers documentation to docs/development.md and expanding it. Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
Kudos, SonarCloud Quality Gate passed! |
@akrejcir Done as requested |
Thanks. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrejcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-functests |
@akrejcir: Overrode contexts on behalf of akrejcir: ci/prow/e2e-functests, ci/prow/e2e-single-node-functests, ci/prow/e2e-upgrade-functests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Enhance documentation by adding resource type / CRD requirements to
README.md and by moving developers documentation to docs/development.md and
expanding it.
Release note: