Fix tests ID 5990 and ID 5989 #365
Conversation
kubevirt-bot
added
release-note-none
|
/retest |
ksimon1
force-pushed
the
handle-update-CR-err
branch
from
fb34617
to
0663cff
Compare
ksimon1
changed the title
tests/webhook_test.go
Outdated
| foundSsp = getSsp() | ||
| foundSsp.Spec.TemplateValidator.Placement = &placementAPIValidationInvalidPlacement | ||
| return apiClient.Update(ctx, foundSsp, client.DryRunAll) | ||
| }, time.Second, tenSecondTimeout).Should(HaveOccurred(), "SSP CR updated with invalid template-validator placement fields") |
There was a problem hiding this comment.
Can you check for specific error here? Like this:
https://github.com/kubevirt/ssp-operator/blob/master/tests/validator_test.go#L797-L798
these tests sometimes failed due to ssp cr conflict error. This patch add retry logic, which tries to update CR multiple time if error occures Signed-off-by: Karel Šimon <ksimon@redhat.com>
ksimon1
force-pushed
the
handle-update-CR-err
branch
from
0663cff
to
3c35e0b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/retest |
|
@ksimon1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/override ci/prow/e2e-functests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/e2e-functests, ci/prow/e2e-single-node-functests, ci/prow/e2e-upgrade-functests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-v0.15 |
|
@ksimon1: new pull request created: #375 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
updated tests ID 5990 and ID 5989
these tests sometimes failed due to ssp cr conflict error.
This patch add retry logic, which tries to update CR multiple time if
error occures
Release note: