-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests ID 5990 and ID 5989 #365
Conversation
/retest |
fb34617
to
0663cff
Compare
tests/webhook_test.go
Outdated
foundSsp = getSsp() | ||
foundSsp.Spec.TemplateValidator.Placement = &placementAPIValidationInvalidPlacement | ||
return apiClient.Update(ctx, foundSsp, client.DryRunAll) | ||
}, time.Second, tenSecondTimeout).Should(HaveOccurred(), "SSP CR updated with invalid template-validator placement fields") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check for specific error here? Like this:
https://github.com/kubevirt/ssp-operator/blob/master/tests/validator_test.go#L797-L798
these tests sometimes failed due to ssp cr conflict error. This patch add retry logic, which tries to update CR multiple time if error occures Signed-off-by: Karel Šimon <ksimon@redhat.com>
0663cff
to
3c35e0b
Compare
Kudos, SonarCloud Quality Gate passed! |
/retest |
@ksimon1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/override ci/prow/e2e-functests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ksimon1: Overrode contexts on behalf of ksimon1: ci/prow/e2e-functests, ci/prow/e2e-single-node-functests, ci/prow/e2e-upgrade-functests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-v0.15 |
@ksimon1: new pull request created: #375 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
updated tests ID 5990 and ID 5989
these tests sometimes failed due to ssp cr conflict error.
This patch add retry logic, which tries to update CR multiple time if
error occures
Release note: