Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common-instancetypes: Add watched cluster CRDs to cleanup func test #469

Merged
merged 1 commit into from
Dec 15, 2022
Merged

common-instancetypes: Add watched cluster CRDs to cleanup func test #469

merged 1 commit into from
Dec 15, 2022

Conversation

lyarwood
Copy link
Member

What this PR does / why we need it:

A quick follow up to #467 to provide functional test coverage of the
behaviour through some existing but previously missed cleanup tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Draft until #467 lands.

Release note:

NONE

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 14, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 14, 2022
@lyarwood
Copy link
Member Author

/cc @0xFelix

@lyarwood
Copy link
Member Author

/test all

@kubevirt-bot
Copy link
Contributor

@lyarwood: No presubmit jobs available for kubevirt/ssp-operator@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyarwood lyarwood force-pushed the fup-common-instancetypes-cleanup-func-test branch from 314944c to 47d1f43 Compare December 14, 2022 14:36
@lyarwood
Copy link
Member Author

/test all

@kubevirt-bot
Copy link
Contributor

@lyarwood: No presubmit jobs available for kubevirt/ssp-operator@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lyarwood
common-instancetypes: Add watched cluster CRDs to cleanup func test
6931856 
A quick follow up to kubevirt#467 to provide functional test coverage of the
behaviour through some existing but previously missed cleanup tests.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
@lyarwood lyarwood force-pushed the fup-common-instancetypes-cleanup-func-test branch from 47d1f43 to 6931856 Compare December 14, 2022 18:24
@lyarwood lyarwood marked this pull request as ready for review December 14, 2022 18:25
@kubevirt-bot kubevirt-bot added size/S and removed size/L do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

0xFelix
0xFelix approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@kubevirt-bot kubevirt-bot merged commit defee3b into kubevirt:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@akrejcir akrejcir Awaiting requested review from akrejcir

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lyarwood @kubevirt-bot @0xFelix