Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_common_test.go: Filter pods for status.phase == Running #478

Merged
merged 1 commit into from
Jan 10, 2023
Merged

tests_common_test.go: Filter pods for status.phase == Running #478

merged 1 commit into from
Jan 10, 2023

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Jan 9, 2023

What this PR does / why we need it:

This avoids race conditions where terminating operator pods are still present when running the next test.

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 9, 2023
@0xFelix 0xFelix changed the title tests_common_test.go: Filter for status.phase == Running tests_common_test.go: Filter pods for status.phase == Running Jan 9, 2023
@0xFelix
tests_common_test.go: Filter pods for status.phase == Running
927ce2d 
This avoids race conditions where terminating operator pods are still
present when running the next test.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ksimon1
Copy link
Member

ksimon1 commented Jan 9, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@0xFelix
Copy link
Member Author

0xFelix commented Jan 10, 2023

/retest

@0xFelix
Copy link
Member Author

0xFelix commented Jan 10, 2023

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2023
@0xFelix
Copy link
Member Author

0xFelix commented Jan 10, 2023

/approve
/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@kubevirt-bot kubevirt-bot merged commit 366a241 into kubevirt:master Jan 10, 2023
@0xFelix 0xFelix mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xFelix @ksimon1 @kubevirt-bot