Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: Introduce Makefile target, introduce pre-commit config and fix issues #495

Merged
merged 10 commits into from
Mar 14, 2023
Merged

lint: Introduce Makefile target, introduce pre-commit config and fix issues #495

merged 10 commits into from
Mar 14, 2023

Commits on Mar 9, 2023

  1. lint: Add Makefile target using golangci-lint 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b338d15 View commit details
    Browse the repository at this point in the history

  2. lint: Add misspell 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b1c7997 View commit details
    Browse the repository at this point in the history

  3. lint: Add ginkgolinter 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    ef51dc2 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. lint: Add errcheck 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9b3bb20 View commit details
    Browse the repository at this point in the history

  2. lint: Add ineffassign 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5ce8bfa View commit details
    Browse the repository at this point in the history

  3. lint: Add staticcheck 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    c143559 View commit details
    Browse the repository at this point in the history

  4. lint: Add unused 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    37505b1 View commit details
    Browse the repository at this point in the history

  5. lint: Add errname 

    Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e4c94ed View commit details
    Browse the repository at this point in the history

  6. pre-commit: Add config and use lint 

    This change introduces pre-commit, a useful framework for ensuring
changes meet certain requirements *before* they are fully committed.

This requires the user install pre-commit itself but this is as easy as:

https://pre-commit.com/#usage

$ pip install --user pre-commit
$ cd path/to/ssp-operator && pre-commit install

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    dbe0f21 View commit details
    Browse the repository at this point in the history

  7. template-validator: Add glog flags to flagset correctly 

    This change removes some older glue code with a native pflag call to
handle the setup of any goflag flags defined by indirect dependencies
like glog. This should be removed when this dependency has gone.

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
    @lyarwood
    lyarwood committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d5c0c85 View commit details
    Browse the repository at this point in the history