refactor: add default update and status functions #544
Conversation
Added default update and status functions for most resources that are reconciled by the operator. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
kubevirt-bot
added
release-note-none
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| case *core.Service: | ||
| foundService := foundObj.(*core.Service) | ||
| // ClusterIP should not be updated |
There was a problem hiding this comment.
The ClusterIP field is set be the API server and is immutable. The problem is that newObj does not have the ClusterIP set, so if we would simply set the sepc:
foundObj.spec = newObj.specit would set ClusterIP to nil, and the update would fail.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
lgtm (not adding /, for awareness of Ben) |
| foundObj.(*promv1.ServiceMonitor).Spec = newTyped.Spec | ||
|
|
||
| default: | ||
| panic(fmt.Sprintf("Default update is not supported for type: %T", newObj)) |
There was a problem hiding this comment.
We'll need to add also pipeline.Task and pipeline.Pipeline after your PR is merged, right?
What this PR does / why we need it:
Added default update and status functions for most resources that are reconciled by the operator.
Release note: