Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add validator image variable to pipeline test scripts #555

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: add validator image variable to pipeline test scripts #555

merged 1 commit into from
May 23, 2023

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented May 23, 2023

What this PR does / why we need it:
fix: add validator image variable to pipeline test scripts

Add validator img link to example pipelines test script. Without this link, validator uses latest tag, which is 3 years old and ssp operator is in deploying phase, because validator is not working

Release note:

NONE

@ksimon1
fix: add validator image variable to pipeline test scripts
0dac4f6 
Add validator img link to example pipelines test script. Without
this link, validator uses latest tag, which is 3 years old and ssp
operator is in deploying phase, because validator is not working

Signed-off-by: Karel Šimon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 23, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ksimon1 by writing /assign @ksimon1 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

0xFelix
0xFelix reviewed May 23, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would make more sense to ensure the latest tag is updated again. Otherwise running make deploy without setting VALIDATOR_IMG is broken for developers too.

@ksimon1
Copy link
Member Author

ksimon1 commented May 23, 2023

IMO it would make more sense to ensure the latest tag is updated again. Otherwise running make deploy without setting VALIDATOR_IMG is broken for developers too.

We have a story for deciding what to do with latest tag and in the near future someone will take care of it

@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@akrejcir
Copy link
Collaborator

@0xFelix , this change is needed regardless of the latest tag, because we want to run CI on containers build from the current PR, not on the one published as latest.

@ksimon1 ksimon1 merged commit b968a39 into kubevirt:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@akrejcir akrejcir

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksimon1 @kubevirt-bot @akrejcir @0xFelix