-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add validator image variable to pipeline test scripts #555
Conversation
Add validator img link to example pipelines test script. Without this link, validator uses latest tag, which is 3 years old and ssp operator is in deploying phase, because validator is not working Signed-off-by: Karel Šimon <ksimon@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it would make more sense to ensure the latest
tag is updated again. Otherwise running make deploy
without setting VALIDATOR_IMG
is broken for developers too.
We have a story for deciding what to do with latest tag and in the near future someone will take care of it |
/lgtm |
@0xFelix , this change is needed regardless of the |
What this PR does / why we need it:
fix: add validator image variable to pipeline test scripts
Add validator img link to example pipelines test script. Without this link, validator uses latest tag, which is 3 years old and ssp operator is in deploying phase, because validator is not working
Release note: