Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Docs: Add branch deprecation notice to README.md #617

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[master] Docs: Add branch deprecation notice to README.md #617

merged 1 commit into from
Jul 4, 2023

Conversation

opokornyy
Copy link
Contributor

What this PR does / why we need it:

This PR adds a notification to the README that the development has been moved from the master branch to the main branch.

Release note:

None

@opokornyy
docs: Update README
5d430db 
Development has been moved from the
master branch to the main branch.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

0xFelix
0xFelix reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just drop the whole branch instead?

@opokornyy
Copy link
Contributor Author

Can't we just drop the whole branch instead?

@lyarwood what do you think about dropping the branch?

@lyarwood
Copy link
Member

lyarwood commented Jul 4, 2023

The only time I've done this in the past we kept master around to point people towards main but that might not be required here so I don't really mind either way. I'd like to hear input from @akrejcir (when you're back next week) , @ksimon1 and @codingben if possible before we decide either way.

@codingben
Copy link
Member

I'd vote to rename master to master-deprecated and keep it, then after a few weeks remove it (or just keep it).

@ksimon1
Copy link
Member

ksimon1 commented Jul 4, 2023

I agree to keep the branch for some time and then removes it

@opokornyy
Copy link
Contributor Author

Can we merge this PR so there is a notification in the README, and then later rename/delete the master branch?

@lyarwood
Copy link
Member

lyarwood commented Jul 4, 2023

Can we merge this PR so there is a notification in the README, and then later rename/delete the master branch?

/lgtm

Okay this works for me.

0xFelix
0xFelix approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

ACK, when do we want to remove the master branch?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023
@kubevirt-bot kubevirt-bot merged commit 2266f09 into kubevirt:master Jul 4, 2023
3 checks passed
@opokornyy
Copy link
Contributor Author

/approve

ACK, when do we want to remove the master branch?

Lets wait for @akrejcir when he is back and then decide.

@akrejcir akrejcir changed the title git rm -rf [main] Docs: Add branch deprecation notice to README.md Jul 11, 2023
@akrejcir
Copy link
Collaborator

In kubevirt they removed the master branch. I think we can keep it temporarily, maybe until the next release, and then remove it.

@akrejcir akrejcir changed the title [main] Docs: Add branch deprecation notice to README.md [master] Docs: Add branch deprecation notice to README.md Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@0xFelix 0xFelix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@opokornyy @lyarwood @codingben @ksimon1 @kubevirt-bot @akrejcir @0xFelix