Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.18] fix: change delete object type in clean up section in efi pipeline #672

Merged
merged 1 commit into from Aug 30, 2023
Merged

[release-v0.18] fix: change delete object type in clean up section in efi pipeline #672

merged 1 commit into from Aug 30, 2023

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #648

/assign ksimon1

fix: change delete object type in clean up section in efi pipeline

@ksimon1
fix: change delete object type in clean up section in efi pipeline
818b880 
CDI changed behaviour of dataVolume garbage collector. It is now
disabled by default. This is causing issue in finally section
of efi pipeline, bceause the pipeline is trying to delete
PVCs, but because the fact, that datavolume is still present, the PVCs
are not deleted.
This commit changes the PVC object name to DataVolume.
Revert PR for DV GC - kubevirt/containerized-data-importer@0bc6a8a
Signed-off-by: Karel Simon <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 30, 2023
@kubevirt-bot kubevirt-bot mentioned this pull request Aug 30, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akrejcir
Copy link
Collaborator

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/win2k22-pipeline-example-test 818b880 link true /test win2k22-pipeline-example-test
ci/prow/win10-pipeline-example-test 818b880 link true /test win10-pipeline-example-test
ci/prow/win11-pipeline-example-test 818b880 link true /test win11-pipeline-example-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ksimon1 ksimon1 merged commit 6190805 into kubevirt:release-v0.18 Aug 30, 2023
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@akrejcir akrejcir

@ksimon1 ksimon1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubevirt-bot @akrejcir @ksimon1