Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add required labels to pods #787

Merged
merged 1 commit into from Jan 11, 2024
Merged

fix: add required labels to pods #787

merged 1 commit into from Jan 11, 2024

Conversation

codingben
Copy link
Member

@codingben codingben commented Dec 19, 2023 •
edited

What this PR does / why we need it:

Add required labels (managed-by, part-of, version, component) to template-validator and vm-console-proxy pods.

Jira-Url: https://issues.redhat.com/browse/CNV-28185

Release note:

Add required labels to template-validator and vm-console-proxy pods.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 19, 2023
@codingben
Copy link
Member Author

/cc @akrejcir @0xFelix @jcanocan

@codingben codingben marked this pull request as draft December 19, 2023 17:02
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2023
0xFelix
0xFelix reviewed Dec 20, 2023
View reviewed changes
internal/common/labels.go Outdated Show resolved Hide resolved
@codingben codingben force-pushed the template-validator-labels branch 5 times, most recently from 78e4c55 to 837468f Compare December 28, 2023 11:38
@codingben codingben changed the title fix: add labels to template-validator pod fix: add required labels to pods Dec 28, 2023
@codingben codingben marked this pull request as ready for review December 28, 2023 11:40
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 28, 2023
@codingben
Copy link
Member Author

I've tested the changes in the cluster and it works as expected.

@jcanocan
Copy link
Contributor

jcanocan commented Jan 2, 2024

Nice job @codingben !
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
akrejcir
akrejcir reviewed Jan 2, 2024
View reviewed changes
internal/common/labels.go Outdated Show resolved Hide resolved
internal/common/labels.go Outdated Show resolved Hide resolved
internal/common/labels_test.go Outdated Show resolved Hide resolved
@akrejcir
Copy link
Collaborator

akrejcir commented Jan 2, 2024

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2024
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@codingben
fix: add required labels to pods
c13b215 
Add required labels (managed-by, part-of, version,
component) to template-validator and vm-console-proxy
pods.

Jira-Url: https://issues.redhat.com/browse/CNV-28185

Signed-off-by: Ben Oukhanov <boukhanov@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@codingben
Copy link
Member Author

@akrejcir @0xFelix @ksimon1 Can you please approve it?

@akrejcir
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@codingben
Copy link
Member Author

/retest

@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
0xFelix
0xFelix approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codingben
Copy link
Member Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@kubevirt-bot kubevirt-bot merged commit e40cbca into kubevirt:main Jan 11, 2024
11 of 12 checks passed
@codingben
Copy link
Member Author

/cherry-pick release-v0.19

@kubevirt-bot
Copy link
Contributor

@codingben: new pull request created: #827

In response to this:

/cherry-pick release-v0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@ksimon1 ksimon1 Awaiting requested review from ksimon1

@opokornyy opokornyy Awaiting requested review from opokornyy

@jcanocan jcanocan Awaiting requested review from jcanocan

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees

@0xFelix 0xFelix

@akrejcir akrejcir

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@codingben @jcanocan @akrejcir @kubevirt-bot @0xFelix