Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.19] fix: add required labels to pods #827

Merged
merged 1 commit into from Jan 12, 2024
Merged

[release-v0.19] fix: add required labels to pods #827

merged 1 commit into from Jan 12, 2024

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #787

/assign codingben

Add required labels to template-validator and vm-console-proxy pods.

@codingben
fix: add required labels to pods
412cb65 
Add required labels (managed-by, part-of, version,
component) to template-validator and vm-console-proxy
pods.

Jira-Url: https://issues.redhat.com/browse/CNV-28185

Signed-off-by: Ben Oukhanov <boukhanov@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Jan 11, 2024
Merged
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jan 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codingben
codingben approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@codingben codingben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@0xFelix
Copy link
Member

0xFelix commented Jan 12, 2024

/retest

@0xFelix
Copy link
Member

0xFelix commented Jan 12, 2024

/test e2e-functests

@kubevirt-bot
Copy link
Contributor Author

@0xFelix: No presubmit jobs available for kubevirt/ssp-operator@release-v0.19

In response to this:

/test e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xFelix
Copy link
Member

0xFelix commented Jan 12, 2024

/test ci/prow/e2e-functests

@kubevirt-bot
Copy link
Contributor Author

@0xFelix: No presubmit jobs available for kubevirt/ssp-operator@release-v0.19

In response to this:

/test ci/prow/e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 12, 2024

@0xFelix: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-functests
  • /test e2e-single-node-functests
  • /test e2e-upgrade-functests
  • /test images
  • /test unittests
  • /test win10-pipeline-example-test
  • /test win11-pipeline-example-test
  • /test win2k22-pipeline-example-test

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-kubevirt-ssp-operator-release-v0.19-e2e-functests
  • pull-ci-kubevirt-ssp-operator-release-v0.19-e2e-single-node-functests
  • pull-ci-kubevirt-ssp-operator-release-v0.19-e2e-upgrade-functests
  • pull-ci-kubevirt-ssp-operator-release-v0.19-images
  • pull-ci-kubevirt-ssp-operator-release-v0.19-unittests

In response to this:

/test ci/prow/e2e-functests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit a53d735 into kubevirt:release-v0.19 Jan 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingben codingben codingben approved these changes

@jcanocan jcanocan Awaiting requested review from jcanocan

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@codingben codingben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubevirt-bot @akrejcir @0xFelix @codingben