Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix owner references in created resources #101

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: Fix owner references in created resources #101

merged 1 commit into from
Mar 5, 2024

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Mar 5, 2024

What this PR does / why we need it:
Fix incorrect ownerReferences. Now the resources will be correctly cleaned up after the VM is deleted.

Which issue(s) this PR fixes:

Fixes: https://issues.redhat.com/browse/CNV-38845

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 5, 2024
@akrejcir
Copy link
Collaborator Author

akrejcir commented Mar 5, 2024

/cc @0xFelix @jcanocan

0xFelix
0xFelix reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
@akrejcir
fix: Fix owner references in created resources
e1edce9 
Now the resources will be correctly cleaned up after the VM
is deleted.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@jcanocan
Copy link

jcanocan commented Mar 5, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@kubevirt-bot kubevirt-bot merged commit 0ba1457 into kubevirt:main Mar 5, 2024
5 checks passed
@akrejcir akrejcir deleted the fix-cleanup branch March 5, 2024 14:39
@akrejcir
Copy link
Collaborator Author

akrejcir commented Apr 2, 2024

/cherry-pick release-v0.4

@kubevirt-bot kubevirt-bot mentioned this pull request Apr 2, 2024
Closed
@kubevirt-bot
Copy link
Contributor

@akrejcir: new pull request created: #116

In response to this:

/cherry-pick release-v0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akrejcir
Copy link
Collaborator Author

akrejcir commented Apr 2, 2024

/cherry-pick release-v0.3

@kubevirt-bot kubevirt-bot mentioned this pull request Apr 2, 2024
Closed
@kubevirt-bot
Copy link
Contributor

@akrejcir: new pull request created: #117

In response to this:

/cherry-pick release-v0.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix left review comments

@jcanocan jcanocan Awaiting requested review from jcanocan

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akrejcir @kubevirt-bot @jcanocan @0xFelix