Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.4] fix: Fix owner references in created resources #116

Closed
wants to merge 1 commit into from
Closed

[release-v0.4] fix: Fix owner references in created resources #116

wants to merge 1 commit into from

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #101

/assign akrejcir

None

@akrejcir
fix: Fix owner references in created resources
3a3d57a 
Now the resources will be correctly cleaned up after the VM
is deleted.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Apr 2, 2024
Merged
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 2, 2024
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akrejcir. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcanocan
Copy link

jcanocan commented Apr 2, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@ksimon1
Copy link
Member

ksimon1 commented Apr 2, 2024

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 2, 2024

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-functests 3a3d57a link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akrejcir
Copy link
Collaborator

akrejcir commented Apr 2, 2024

This needs a manual fix.

/close

@kubevirt-bot
Copy link
Contributor Author

@akrejcir: Closed this PR.

In response to this:

This needs a manual fix.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcanocan jcanocan Awaiting requested review from jcanocan

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@akrejcir akrejcir

@ksimon1 ksimon1

@jcanocan jcanocan

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubevirt-bot @jcanocan @ksimon1 @akrejcir