This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
deprecate usage of flavor.template.kubevirt.io/Custom label #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: no
Signed-off-by: suomiy <suomiy@gmail.com>
atiratree
force-pushed
the
remove-custom-label
branch
from
156d1c8
to
fd65728
Compare
kubevirt-bot
added
dco-signoff: yes
pkliczewski
approved these changes
May 18, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pkliczewski, suomiy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkliczewski
added
the
release-note-none
kubevirt-bot
removed
the
do-not-merge/release-note-label-needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we decided it was not useful keeping this label around (openshift/console#5250). So currently designation of custom flavor is when flavor label is missing - as it should be.