Bug 1788810: deprecate usage of flavor.template.kubevirt.io/Custom label #5250
Conversation
atiratree
commented
Apr 30, 2020
•
atiratree
commented
- use Custom only internally by the UI and acknowledge missing label as Custom flavor
- remove kubevirt.io/size: Custom label as well
- capitalize flavors in VM Wizard
- fix display of VM template flavor
openshift-ci-robot
added
bugzilla/severity-low
|
@suomiy: This pull request references Bugzilla bug 1788810, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
atiratree
force-pushed
the
bug.1788810
branch
2 times, most recently
from
9919b8b
to
9e4bffb
Compare
| @@ -19,5 +20,5 @@ export const getFlavorText = ({ | |||
| const memoryBase = convertToBytes(memory); | |||
| const memoryText = humanizeBinaryBytes(memoryBase).string; | |||
|
|
|||
| return `${_.capitalize(flavor) || ''}${flavor ? ': ' : ''}${vcpusText}, ${memoryText} Memory`; | |||
| return `${_.capitalize(alignLegacyFlavor(flavor))}: ${vcpusText}, ${memoryText} Memory`; | |||
There was a problem hiding this comment.
do we need to check for "Custom" here ?
If it's the legacy "Custom", turning it to "custom" before turning it back to "Custom" does nothing.
There was a problem hiding this comment.
This is mainly to show Custom even when the flavor is missing.
This begs a question: shouldn't we remove the custom label altogether and treat missing flavor label as custom every time?
I mean this is already happening, but we probably don't need two approaches to this.
what do you think?
There was a problem hiding this comment.
+1 i'm for removing the custom label ...
are we the only one's using this label ?
There was a problem hiding this comment.
cool, will change the PR then,
yes, we are although vm-import-operator started using it too, but it should be easy for them to drop it
- use Custom only internally by the UI and acknowledge missing label as Custom flavor - remove kubevirt.io/size: Custom label as well - capitalize flavors in VM Wizard - fix display of VM template flavor
atiratree
changed the title
|
@suomiy: This pull request references Bugzilla bug 1788810, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yaacov changed the PR to deprecate the usage of Custom label in the entities |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
maybe we should close and re-open ? |
|
ok |
|
@suomiy: This pull request references Bugzilla bug 1788810, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@suomiy: All pull requests linked via external trackers have merged: openshift/console#5250. Bugzilla bug 1788810 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
