Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Validate the target VM name and ensure uniqueness #450

Merged
2 commits merged into from
Dec 10, 2020

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Dec 9, 2020

Validates the format of the targetVMName or the source VM name if the target name was not provided. Also ensures that there is not already a VirtualMachine in the namespace with that name.

Removing the normalization can be a follow up, but it should be harmless for now since any names that would be normalized should be caught by the validation.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1894825

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@kubevirt-bot
Copy link

@mansam: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L labels Dec 9, 2020
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fdupont-redhat, mansam
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost ghost merged commit 2bf8982 into kubevirt:master Dec 10, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants