feat(qrm): implement a native policy for cpu qrm plugin #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohe
added
workflow/draft
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 51.21% 50.95% -0.26%
==========================================
Files 412 418 +6
Lines 39094 40409 +1315
==========================================
+ Hits 20023 20592 +569
- Misses 16834 17562 +728
- Partials 2237 2255 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
caohe
force-pushed
the
add-native-policy
branch
5 times, most recently
from
38e98ba
to
6aad57f
Compare
caohe
requested review from
waynepeking348,
luomingmeng and
csfldf
and removed request for
waynepeking348
caohe
added
workflow/need-review
20 tasks
caohe
added
workflow/merge-ready
caohe
force-pushed
the
add-native-policy
branch
2 times, most recently
from
fcdbe8f
to
f90628a
Compare
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
caohe
force-pushed
the
add-native-policy
branch
4 times, most recently
from
a2de941
to
269b5be
Compare
Signed-off-by: caohe <caohe9603@gmail.com>
csfldf
previously approved these changes
Jul 26, 2023
| @@ -402,6 +407,7 @@ func (ns *NUMANodeState) SetAllocationInfo(podUID string, containerName string, | |||
| } | |||
|
|
|||
| // GetDefaultCPUSet returns default cpuset in this node | |||
| // TODO: add lock to NUMANodeMap | |||
There was a problem hiding this comment.
since stateCheckpoint functions are all under locks, it seems that we don't need to add lock in the operations in
specifc state struct.
pkg/consts/qrm.go
Outdated
| @@ -19,4 +19,16 @@ package consts | |||
| const ( | |||
| // KubeletQoSResourceManagerCheckpoint is the name of the checkpoint file for kubelet QoS resource manager | |||
| KubeletQoSResourceManagerCheckpoint = "kubelet_qrm_checkpoint" | |||
|
|
|||
| // CPUResourcePluginPolicyNameDynamic is the name of the dynamic policy. | |||
| CPUResourcePluginPolicyNameDynamic = "dynamic" | |||
There was a problem hiding this comment.
would it be better to put cpu related consts under cpu package?
| SkipCPUStateCorruption: false, | ||
| EnableCPUPressureEviction: false, | ||
| EnableSyncingCPUIdle: false, | ||
| EnableCPUIdle: false, |
There was a problem hiding this comment.
maybe it's better to separate options/configs for different policies, ie.
- define general options/configs in
CPUOptions/CPUConfigurations - define native-policy-specified options/configs in
CPUNativePolicyOptions/CPUNativePolicyConfigurations - define dynamic-policy-specified options/configs in
CPUDynamicPolicyOptions/CPUDynamicPolicyConfiguration
waynepeking348
previously approved these changes
Jul 27, 2023
Signed-off-by: caohe <caohe9603@gmail.com>
csfldf
approved these changes
Jul 27, 2023
waynepeking348
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
This PR needs #150 to be merged first.