Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod propagation should disable the use of custom pod informer #64

Open
limhawjia opened this issue May 12, 2023 · 1 comment
Open

Pod propagation should disable the use of custom pod informer #64

limhawjia opened this issue May 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@limhawjia
Copy link
Collaborator

PR #46 introduces a custom pod informer that transform pod objects before caching.

With support for pod federation, we need to ensure that this custom pod informer is disabled for certain pod subcontrollers to work properly, e.g. sync, status

@SOF3
Copy link
Member

SOF3 commented May 12, 2023

Should we just pass a separate informer for pruned pods instead of intrusively modifying the pod informer for all use cases that didn't want pruning?

@gary-lgy gary-lgy added the enhancement New feature or request label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants