update arm64 assembly to link/build on apple silicon mac #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the arm64 assembly code, to resolve the issues brought up here.
Trying to build it from the original source here results in the assembler complaining:
This is because the assembler for arm64 mac doesn't support that directive. Additionally, the naming of symbols defined in assembly is different.
I made a copy of the aarch64 asm files and fixed the syntax, so that it properly builds and links for arm64 mac. I also ran the tests with these results: