Add Telemetry Hex Storage Format #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hey there @cnalley, nice to see you! Thanks for the PR, we'll have a look. |
davesims
reviewed
Jun 16, 2017
| int len = 0; | ||
| const unsigned char *byte_array = (unsigned char*)&packet; | ||
|
|
||
| if (data_buf_ptr == NULL) |
There was a problem hiding this comment.
Seems like this guard could move to the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hex format telemetry log entry. The log entry is fixed width hexadecimal and contains the entire contents of the telemetry packet struct. This format can be used with the telemetry plotter here https://github.com/cnalley/telemetry-plotter. Some additional placeholders were also added for future output formats. The existing csv format only saves the data member of the telemetry struct while the new hex format saves the entire telemetry packet. The two new placeholders would in the future provide a hex format to save just the data member of the telemetry packet struct and a csv format for the complete telemetry packet. These new formats would open up additional configuration options for klog to leave all telemetry logs in the same file (if it's a complete telemetry packet for later decoding) or just the data member if each telemetry source is saved to individual files with distinct file names.