Negotiate Docker API version before attempting to create node volumes…

… in tests. (#840)

* Negotiate Docker API version before attempting to create node volumes in tests.

* fully implement DockerClient in mock

pkg/test/harness.go

@@ -154,6 +154,9 @@ func (h *Harness) addNodeCaches(kindCfg *kindConfig.Cluster) error {
 		return err
 	}
 
+	// Determine the correct API version to use with the user's Docker client.
+	dockerClient.NegotiateAPIVersion(context.TODO())
+
 	// add a default node if there are none specified.
 	if len(kindCfg.Nodes) == 0 {
 		kindCfg.Nodes = append(kindCfg.Nodes, kindConfig.Node{})

pkg/test/harness_test.go

@@ -28,6 +28,8 @@ func (d *dockerMock) VolumeCreate(ctx context.Context, body volumetypes.VolumeCr
 	}, nil
 }
 
+func (d *dockerMock) NegotiateAPIVersion(ctx context.Context) {}
+
 func TestAddNodeCaches(t *testing.T) {
 	h := Harness{
 		T:      t,

pkg/test/utils/docker.go

@@ -9,5 +9,6 @@ import (
 
 // DockerClient is a wrapper interface for the Docker library to support unit testing.
 type DockerClient interface {
+	NegotiateAPIVersion(context.Context)
 	VolumeCreate(context.Context, volumetypes.VolumeCreateBody) (dockertypes.Volume, error)
 }