Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negotiate Docker API version before attempting to create node volumes in tests. #840

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

jbarrick-mesosphere
Copy link
Member

What this PR does / why we need it:

This adds a call to NegotiateAPIVersion() when initializing our Docker API client so that it will work with any Docker version:

harness.go:172: error creating volume for node Error response from daemon: client version 1.41 is too new. Maximum supported API version is 1.39

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jbarrick-mesosphere jbarrick-mesosphere merged commit 29b2048 into master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants