Don't warn if parameter is only used as trigger (#1618)

Parameters can be used to only trigger plans without being used in any templates. In this case no warning should be printed when verifying a package.

Signed-off-by: Jan Schlicht <jan@d2iq.com>

pkg/kudoctl/cmd/testdata/invalid-params.golden

@@ -1,6 +1,5 @@
-Warnings                                
-parameter "Cpus" defined but not used.  
-parameter "comma," defined but not used.
+Warnings                              
+parameter "Cpus" defined but not used.
 Errors                                                            
 parameter "Cpus" has a duplicate                                  
 parameter "comma," contains invalid character ','                 

pkg/kudoctl/packages/verifier/template/verify_parameters.go

@@ -81,7 +81,10 @@ func paramsDefinedNotUsed(pf *packages.Files) verifier.Result {
 	}
 	for _, value := range pf.Params.Parameters {
 		if _, ok := tparams[value.Name]; !ok {
-			res.AddParamWarning(value.Name, "defined but not used.")
+			// A parameter could be use to trigger a plan while not being used in templates.
+			if value.Trigger == "" {
+				res.AddParamWarning(value.Name, "defined but not used.")
+			}
 		}
 	}
 	return res

pkg/kudoctl/packages/verifier/template/verify_parameters_test.go

@@ -17,6 +17,7 @@ func TestTemplateParametersVerifier(t *testing.T) {
 		{Name: "UsedViaRoot"},
 		{Name: "BROKER_COUNT"},
 		{Name: "EXTERNAL_NODE_PORT"},
+		{Name: "TRIGGER_ONLY", Trigger: "foo"},
 	}
 	paramFile := packages.ParamsFile{Parameters: params}
 	templates := make(map[string]string)