Fix trailing newlines when printing errors. (#1270)

This changes fmt.Printf to clog.Printf since the former does not produce a trailing newline.

pkg/engine/task/podexec/pod_exec.go

@@ -6,6 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"log"
 	"os"
 	"strconv"
 	"strings"
@@ -196,7 +197,7 @@ func untarFile(fs afero.Fs, r io.Reader, fileName string) error {
 			}
 
 		default:
-			fmt.Printf("skipping %s because it is not a regular file or a directory", header.Name)
+			log.Printf("skipping %s because it is not a regular file or a directory", header.Name)
 		}
 	}
 

pkg/kudoctl/cmd/plan/plan_history.go

@@ -8,6 +8,7 @@ import (
 	"github.com/spf13/cobra"
 	"github.com/xlab/treeprint"
 
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/env"
 )
 
@@ -41,15 +42,15 @@ func planHistory(options *Options, settings *env.Settings) error {
 
 	kc, err := env.GetClient(settings)
 	if err != nil {
-		fmt.Printf("Unable to create kudo client to talk to kubernetes API server %v", err)
+		clog.Printf("Unable to create KUDO client to talk to kubernetes API server: %v", err)
 		return err
 	}
 	instance, err := kc.GetInstance(options.Instance, namespace)
 	if err != nil {
 		return err
 	}
 	if instance == nil {
-		return fmt.Errorf("instance %s/%s does not exist", namespace, options.Instance)
+		return clog.Errorf("instance %s/%s does not exist", namespace, options.Instance)
 	}
 
 	tree := treeprint.New()

pkg/kudoctl/cmd/update.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/spf13/cobra"
 
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/cmd/install"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/env"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/util/kudo"
@@ -99,6 +100,6 @@ func update(instanceToUpdate string, kc *kudo.Client, options *updateOptions, se
 	if err != nil {
 		return fmt.Errorf("updating instance %s %w", instanceToUpdate, err)
 	}
-	fmt.Printf("Instance %s was updated.", instanceToUpdate)
+	clog.Printf("Instance %s was updated.", instanceToUpdate)
 	return nil
 }

pkg/kudoctl/http/http_client.go

@@ -8,6 +8,7 @@ import (
 	"net/url"
 	"strings"
 
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 	"github.com/kudobuilder/kudo/pkg/version"
 )
 
@@ -37,11 +38,11 @@ func (c *Client) Get(href string) (*bytes.Buffer, error) {
 
 	_, err = io.Copy(buf, resp.Body)
 	if err != nil {
-		fmt.Printf("Error when copying response buffer %s", err)
+		clog.Printf("Error when copying response buffer %s", err)
 	}
 	err = resp.Body.Close()
 	if err != nil {
-		fmt.Printf("Error when closing the response body %s", err)
+		clog.Printf("Error when closing the response body %s", err)
 	}
 	return buf, err
 }

pkg/kudoctl/packages/reader/reader_tar.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/spf13/afero"
 
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/packages"
 )
 
@@ -47,7 +48,7 @@ func ParseTgz(r io.Reader) (*packages.Files, error) {
 	defer func() {
 		err := gzr.Close()
 		if err != nil {
-			fmt.Printf("Error when closing gzip reader: %s", err)
+			clog.Printf("Error when closing gzip reader: %s", err)
 		}
 	}()
 

pkg/kudoctl/packages/writer/writer_tar.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/spf13/afero"
 
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/files"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/packages"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/packages/reader"
@@ -69,7 +70,7 @@ func TgzDir(fs afero.Fs, path string, w io.Writer) (err error) {
 		// create a new dir/file header
 		header, err := tar.FileInfoHeader(fi, fi.Name())
 		if err != nil {
-			fmt.Printf("Error creating tar header for: %v", fi.Name())
+			clog.Printf("Error creating tar header for: %v", fi.Name())
 			return err
 		}
 

pkg/kudoctl/util/repo/digest.go

@@ -2,12 +2,12 @@ package repo
 
 import (
 	"bytes"
-	"fmt"
 	"io"
 	"io/ioutil"
 
 	"github.com/spf13/afero"
 
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/files"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/packages"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/packages/reader"
@@ -30,7 +30,7 @@ func mapPaths(fs afero.Fs, paths []string, f func(afero.Fs, string) (*PackageFil
 	for _, path := range paths {
 		op, err := f(fs, path)
 		if err != nil {
-			fmt.Printf("WARNING: operator: %v is invalid", path)
+			clog.Printf("WARNING: operator: %v is invalid", path)
 			continue
 		}
 		ops = append(ops, op)

pkg/kudoctl/util/repo/index.go

@@ -12,6 +12,7 @@ import (
 	"github.com/spf13/afero"
 	"sigs.k8s.io/yaml"
 
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/packages"
 )
 
@@ -109,7 +110,7 @@ func (i IndexFile) Write(w io.Writer) error {
 	}
 	_, err = w.Write(b)
 	if err != nil {
-		fmt.Printf("err: %v", err)
+		clog.Printf("Error writing index file: %v", err)
 	}
 	return err
 }

pkg/test/harness.go

@@ -28,6 +28,7 @@ import (
 	"github.com/kudobuilder/kudo/pkg/controller/instance"
 	"github.com/kudobuilder/kudo/pkg/controller/operator"
 	"github.com/kudobuilder/kudo/pkg/controller/operatorversion"
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 	testutils "github.com/kudobuilder/kudo/pkg/test/utils"
 )
 
@@ -283,7 +284,7 @@ func (h *Harness) RunKUDO() error {
 	h.managerStopCh = make(chan struct{})
 	go func(stopCh chan struct{}) {
 		if err := mgr.Start(stopCh); err != nil {
-			fmt.Printf("failed to start the manager")
+			clog.Printf("failed to start the manager: %v", err)
 			os.Exit(-1)
 		}
 	}(h.managerStopCh)

pkg/test/utils/kubernetes.go

@@ -51,6 +51,7 @@ import (
 
 	"github.com/kudobuilder/kudo/pkg/apis"
 	harness "github.com/kudobuilder/kudo/pkg/apis/testharness/v1beta1"
+	"github.com/kudobuilder/kudo/pkg/kudoctl/clog"
 )
 
 // ensure that we only add to the scheme once.
@@ -260,11 +261,11 @@ func (r *RetryStatusWriter) Patch(ctx context.Context, obj runtime.Object, patch
 func Scheme() *runtime.Scheme {
 	schemeLock.Do(func() {
 		if err := apis.AddToScheme(scheme.Scheme); err != nil {
-			fmt.Printf("failed to add API resources to the scheme: %v", err)
+			clog.Printf("failed to add API resources to the scheme: %v", err)
 			os.Exit(-1)
 		}
 		if err := apiextensions.AddToScheme(scheme.Scheme); err != nil {
-			fmt.Printf("failed to add API extension resources to the scheme: %v", err)
+			clog.Printf("failed to add API extension resources to the scheme: %v", err)
 			os.Exit(-1)
 		}
 	})