Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trailing newlines when printing errors. #1270

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix trailing newlines when printing errors. #1270

merged 1 commit into from
Jan 16, 2020

Conversation

porridge
Copy link
Member

What this PR does / why we need it:

This changes fmt.Printf to clog.Printf since the former does not produce a trailing newline.

Fixes #1267

zen-dog
zen-dog approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _______________
< Log all things! >
  ---------------
         \   ^__^ 
          \  (oo)\_______
             (__)\       )\/\
                 ||----w |
                 ||     ||

@porridge porridge merged commit 99bd696 into master Jan 16, 2020
@porridge porridge deleted the log-newlines branch January 16, 2020 09:08
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
@porridge @ANeumann82
Fix trailing newlines when printing errors. (#1270)
d8ab18a 
This changes fmt.Printf to clog.Printf since the former does not produce a trailing newline.

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@ANeumann82 ANeumann82 ANeumann82 approved these changes

@zen-dog zen-dog zen-dog approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@jbarrick-mesosphere jbarrick-mesosphere Awaiting requested review from jbarrick-mesosphere jbarrick-mesosphere is a code owner

@nfnt nfnt Awaiting requested review from nfnt nfnt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package update output does not end in endline
4 participants
@porridge @kensipe @ANeumann82 @zen-dog