Skip to content

Commit

Permalink
Improve test transparency. (#1209)
Browse files Browse the repository at this point in the history
* Show the actual binary which is run.
* Show what commands are being run.
  This makes it easier to get the most focused command for the thing that is failing.
  • Loading branch information
porridge committed Dec 20, 2019
1 parent ec73f07 commit cbdfb88
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions hack/run-e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
set -o errexit
set -o nounset
set -o pipefail
set -o xtrace

INTEGRATION_OUTPUT_JUNIT=${INTEGRATION_OUTPUT_JUNIT:-false}

Expand Down
1 change: 1 addition & 0 deletions hack/run-integration-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
set -o errexit
set -o nounset
set -o pipefail
set -o xtrace

INTEGRATION_OUTPUT_JUNIT=${INTEGRATION_OUTPUT_JUNIT:-false}

Expand Down
2 changes: 1 addition & 1 deletion pkg/test/utils/kubernetes.go
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ func RunCommands(logger Logger, namespace string, command string, commands []kud
stdout := &bytes.Buffer{}
stderr := &bytes.Buffer{}

logger.Log("Running command:", cmd)
logger.Logf("Running command: %s %s", command, cmd)

err := RunCommand(context.TODO(), namespace, command, cmd, workdir, stdout, stderr)
if err != nil {
Expand Down

0 comments on commit cbdfb88

Please sign in to comment.