Improve test transparency. #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to get the most focused command for the thing that is failing.
porridge
requested review from
alenkacz,
gerred,
jbarrick-mesosphere,
kensipe,
nfnt and
zen-dog
as code owners
nfnt
reviewed
Dec 19, 2019
| @@ -942,7 +942,7 @@ func RunCommands(logger Logger, namespace string, command string, commands []kud | |||
| stdout := &bytes.Buffer{} | |||
| stderr := &bytes.Buffer{} | |||
|
|
|||
| logger.Log("Running command:", cmd) | |||
| logger.Logf("Running command: %s %s", command, cmd) | |||
There was a problem hiding this comment.
The handling of command in RunCommands is weird, most of the time it's an empty string. I'd rather have us refactor these functions. But this isn't the scope of this PR, and as this improves logging for the case that command == "kubectl", I'm fine with this addition.
alenkacz
approved these changes
Dec 19, 2019
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Show the actual binary which is run. * Show what commands are being run. This makes it easier to get the most focused command for the thing that is failing. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Show what commands are being run.
This makes it easier to get the most focused command for the thing that is
failing.
Show the actual binary which is run.