Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go integration tests can return "unexpected end of JSON input" #526

Closed
jbarrick-mesosphere opened this issue Jul 8, 2019 · 0 comments · Fixed by #547
Closed

Go integration tests can return "unexpected end of JSON input" #526

jbarrick-mesosphere opened this issue Jul 8, 2019 · 0 comments · Fixed by #547
Labels
component/testing flaky test kind/bug

Comments

@jbarrick-mesosphere
Copy link
Member

jbarrick-mesosphere commented Jul 8, 2019 •
edited
Loading

What happened:

Some of the Go-based integration tests are flaky returning "unexpected end of JSON input".

We have fixed this for the declarative harness before (#415), however, the Go-based integration tests are not currently doing any retries.

https://circleci.com/gh/kudobuilder/kudo/2235
jbarrick-mesosphere added a commit to jbarrick-mesosphere/kudo that referenced this issue Jul 10, 2019
@jbarrick-mesosphere
Implement a new RetryClient that wraps the Kubernetes Client with ret…
630646a 
…ries.

Fixes kudobuilder#526

This ensures that we properly retry on network failures in our integration tests to prevent an flaky tests.
@jbarrick-mesosphere jbarrick-mesosphere mentioned this issue Jul 10, 2019
Merged
jbarrick-mesosphere added a commit that referenced this issue Jul 10, 2019
@jbarrick-mesosphere
Implement a new RetryClient that wraps the Kubernetes Client with ret…
3befd46 
…ries. (#547)

Fixes #526

This ensures that we properly retry on network failures in our integration tests to prevent an flaky tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/testing flaky test kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement a new RetryClient that wraps the Kubernetes Client with retries jbarrick-mesosphere/kudo
1 participant
@jbarrick-mesosphere