Implement a new RetryClient that wraps the Kubernetes Client with retries #547
Conversation
…ries. Fixes kudobuilder#526 This ensures that we properly retry on network failures in our integration tests to prevent an flaky tests.
|
This looks good! Do you think you'd get any value in swapping the underlying implementation to https://github.com/hashicorp/go-retryablehttp? I've had success with it in the past, but it looks like the way your doing it is a lot more Kubernetes client specific (with the status retrier). I have no preferences but wanted to make sure you were aware of it. :) |
Yeah, that looks HTTP-specific, whereas this is focused on Kubernetes. We could swap the existing Retry method for something from another library, but I implemented my own as I wasn't sure if we wanted to pull in a new dependency just for that (and the ones that I found in the Kubernetes library didn't work the way I needed / had confusing interfaces). |
|
Nope, sgtm. I'd rather have a new function than a new dependency. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Implement a new RetryClient that wraps the Kubernetes Client with retries
This ensures that we properly retry on network failures in our integration tests to prevent an flaky tests.
Which issue(s) this PR fixes:
Fixes #526
Does this PR introduce a user-facing change?: