-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Appversion in operator.yaml templatable. #1026
Conversation
I modified the first-operator with {{ .AppVersion }} to test this, should I commit that too?? @alenkacz ^ |
@sivaramsk oh yeah, that would be lovely, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 👏 thank you!
A nice addition would be documenting the new variable in here https://github.com/kudobuilder/www/blob/master/content/docs/developing-operators.md#variables-provided-by-kudo
Thanks @alenkacz. I will document the changes in that page. |
Thanks @sivaramsk 🎉 |
What this PR does / why we need it:
Make the version and appVersion variables in operator.yaml as a template to statefulset.yaml. This is still a WIP, and creating this PR as I need guidance in completing this.
Fixes #871