Make Appversion in operator.yaml templatable. #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaramsk
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
|
I modified the first-operator with {{ .AppVersion }} to test this, should I commit that too?? @alenkacz ^ |
|
@sivaramsk oh yeah, that would be lovely, thanks |
alenkacz
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
This looks good 👏 thank you!
A nice addition would be documenting the new variable in here https://github.com/kudobuilder/www/blob/master/content/docs/developing-operators.md#variables-provided-by-kudo
|
Thanks @alenkacz. I will document the changes in that page. |
|
Thanks @sivaramsk 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make the version and appVersion variables in operator.yaml as a template to statefulset.yaml. This is still a WIP, and creating this PR as I need guidance in completing this.
Fixes #871