-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding KEP template #107
Conversation
After some conversation, @fabianbaier and I determined the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would like something that specifies WHEN a KEP is needed, but that's outside the scope of this template
Could we add some link (maybe also note when to use) to the Readme/Contributor Guide? |
I like this here (also for when to use) |
@@ -0,0 +1,159 @@ | |||
--- | |||
kep-number: 0 | |||
title: My First KEP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/KEP/ Kubernetes Enhancement Proposal (KEP)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KEP stands for KUDO Enhancement Proposal, not Kubernetes Enhancement Proposal. I would also keep the title short.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy past error ;-). I would still explain the abbreviation somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed.
keps/0000-kep-template.md
Outdated
|
||
# Title | ||
|
||
This is the title of the KEP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/KEP/Kubernetes Enhancement Proposal (KEP)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
|
||
The `Metadata` section above is intended to support the creation of tooling around the KEP process. | ||
This will be a YAML section that is fenced as a code block. | ||
See the KEP process for details on each of these items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean to this one https://github.com/kubernetes/enhancements/blob/master/keps/0001-kubernetes-enhancement-proposal-process.md or our own?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one are you referring to here See the KEP process for details on each of these items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the one that will be 0001-kudo-enhancement-proposal-process.md
- which is a separate PR to the template. Not yet in the making, that's why not linked.
This is a work-in-progress, please iterate on it. It relates to/blocks #99.