Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding KEP template #107

Merged
merged 4 commits into from
Feb 13, 2019
Merged

[WIP] Adding KEP template #107

merged 4 commits into from
Feb 13, 2019

Conversation

fabianbaier
Copy link
Member

This is a work-in-progress, please iterate on it. It relates to/blocks #99.

keps/0000-kep-template.md Outdated Show resolved Hide resolved
keps/0000-kep-template.md Outdated Show resolved Hide resolved
keps/0000-kep-template.md Outdated Show resolved Hide resolved
@gerred
Copy link
Member

gerred commented Feb 12, 2019

After some conversation, @fabianbaier and I determined the owners key is a list of champions for the KEP. These people are responsible for either providing or getting the resources they need to deliver this KEP. The OWNERS file still determines reviewers/approvers.

Copy link
Member

@runyontr runyontr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would like something that specifies WHEN a KEP is needed, but that's outside the scope of this template

@joerg84
Copy link
Contributor

joerg84 commented Feb 12, 2019

Could we add some link (maybe also note when to use) to the Readme/Contributor Guide?

@joerg84
Copy link
Contributor

joerg84 commented Feb 12, 2019

Could we add some link (maybe also note when to use) to the Readme/Contributor Guide?

I like this here (also for when to use)
https://github.com/kubernetes/enhancements/

@@ -0,0 +1,159 @@
---
kep-number: 0
title: My First KEP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/KEP/ Kubernetes Enhancement Proposal (KEP)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KEP stands for KUDO Enhancement Proposal, not Kubernetes Enhancement Proposal. I would also keep the title short.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy past error ;-). I would still explain the abbreviation somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed.


# Title

This is the title of the KEP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/KEP/Kubernetes Enhancement Proposal (KEP)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same


The `Metadata` section above is intended to support the creation of tooling around the KEP process.
This will be a YAML section that is fenced as a code block.
See the KEP process for details on each of these items.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a link?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one are you referring to here See the KEP process for details on each of these items.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is the one that will be 0001-kudo-enhancement-proposal-process.md - which is a separate PR to the template. Not yet in the making, that's why not linked.

@gerred gerred merged commit 61f6009 into master Feb 13, 2019
@gerred gerred deleted the adding-kep-template branch February 13, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants