Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored instance validation webhook #1207

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Refactored instance validation webhook #1207

merged 2 commits into from
Dec 19, 2019

Commits on Dec 18, 2019

  1. Refactored instance validation webhook 

    Summary:
existing `Validator` interface was removed, we're now using the underlying `http.Handler` interface to register webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook)
    @zen-dog
    zen-dog committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    c5ea2b0 View commit details
    Browse the repository at this point in the history

  2. Added method comments

    @zen-dog
    zen-dog committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    dd931ff View commit details
    Browse the repository at this point in the history