Refactored instance validation webhook #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: existing `Validator` interface was removed, we're now using the underlying `http.Handler` interface to register webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook)
zen-dog
commented
Dec 18, 2019
| // A client will be automatically injected. | ||
|
|
||
| // InjectClient injects the client. | ||
| func (v *InstanceValidator) InjectClient(c client.Client) error { |
There was a problem hiding this comment.
Strictly speaking, this webhook doesn't need the client but I intend for this webhook to be a template for future ones so I kept it here.
alenkacz
approved these changes
Dec 19, 2019
| // registerWebhook method registers passed webhook using a give prefix (e.g. "/validate") and runtime object | ||
| // (e.g. v1beta1.Instance) to generate a webhook path e.g. "/validate-kudo-dev-v1beta1-instances". Webhook | ||
| // has to implement http.Handler interface (see v1beta1.InstanceValidator for an example) | ||
| func registerWebhook(prefix string, obj runtime.Object, hook http.Handler, mgr manager.Manager) error { |
There was a problem hiding this comment.
even nicer would be to have a webhook type that would then map to this prefix :) but we can improve on that :)
There was a problem hiding this comment.
yep. let's see what abstractions will prove themselves useful once we add more hooks.
kensipe
added a commit
that referenced
this pull request
Dec 27, 2019
zen-dog
pushed a commit
that referenced
this pull request
Dec 28, 2019
Summary: existing `Validator` interface was removed, we're now using the underlying `http.Handler` interface to register webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook) (cherry picked from commit 366222d)
zen-dog
added a commit
that referenced
this pull request
Dec 28, 2019
kensipe
pushed a commit
that referenced
this pull request
Dec 30, 2019
* Refactored instance validation webhook (#1207) Summary: existing `Validator` interface was removed, we're now using the underlying `http.Handler` interface to register webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook) (cherry picked from commit 366222d) * Reintroduce 366222d (#1207) Additionally: - excluded `instance_validator.go` from code generation - and fixed an erroneous client import
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Summary: existing `Validator` interface was removed, we're now using the underlying `http.Handler` interface to register webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook) Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Refactored instance validation webhook (#1207) Summary: existing `Validator` interface was removed, we're now using the underlying `http.Handler` interface to register webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook) (cherry picked from commit 366222d) * Reintroduce 366222d (#1207) Additionally: - excluded `instance_validator.go` from code generation - and fixed an erroneous client import Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
existing
Validatorinterface was removed, we're now using the underlyinghttp.Handlerinterface to implement webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook)