Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test transparency. #1209

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Improve test transparency. #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d58ec9
Show the actual binary which is run.
porridge Dec 19, 2019
ddfa5a0
Show what commands are being run.
porridge Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hack/run-e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
set -o errexit
set -o nounset
set -o pipefail
set -o xtrace

INTEGRATION_OUTPUT_JUNIT=${INTEGRATION_OUTPUT_JUNIT:-false}

Expand Down
1 change: 1 addition & 0 deletions hack/run-integration-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
set -o errexit
set -o nounset
set -o pipefail
set -o xtrace

INTEGRATION_OUTPUT_JUNIT=${INTEGRATION_OUTPUT_JUNIT:-false}

Expand Down
2 changes: 1 addition & 1 deletion pkg/test/utils/kubernetes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ func RunCommands(logger Logger, namespace string, command string, commands []kud
stdout := &bytes.Buffer{}
stderr := &bytes.Buffer{}

logger.Log("Running command:", cmd)
logger.Logf("Running command: %s %s", command, cmd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handling of command in RunCommands is weird, most of the time it's an empty string. I'd rather have us refactor these functions. But this isn't the scope of this PR, and as this improves logging for the case that command == "kubectl", I'm fine with this addition.


err := RunCommand(context.TODO(), namespace, command, cmd, workdir, stdout, stderr)
if err != nil {
Expand Down