Rename the CRD files. #1210
Merged
Rename the CRD files. #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was never used (verified by eyeballing `git log -p` all the way down), we don't seem to know what it's for, and it has no counterpart in the structs.
This is in preparation for moving to `controller-gen`, which is somewhat opinionated in that it does not allow us to pick the exact file names. I guess we do not really care what these are called anyway - the only place where these names show up is this integration test.
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
alenkacz
reviewed
Dec 19, 2019
May I ask why it matters?
Looks like this will be handled automagically If we have more than one.
Looking at that code, it doesn't seem like it... |
alenkacz
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
May I ask why it matters? - just a matter of taste
Looks like this will be handled automagically If we have more than one. - oh that's version of CRD resource, not version of our CRDs, anyway, now I realized that multiple versions are actually represented by one yaml so all good. 👍
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
This is in preparation for moving to `controller-gen`, which is somewhat opinionated in that it does not allow us to pick the exact file names. I guess we do not really care *that much* what these are called anyway - the only place where these names show up is this integration test. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is in preparation for moving to
controller-gen, which is somewhatopinionated in that it does not allow us to pick the exact file names.
I guess we do not really care what these are called anyway - the only
place on all of GitHub where these names show up is this integration test - so pleasing controller-gen now will make future diffs smaller.
This is another baby step towards #862