Use go-bindata to embed YAML files with CRDs. #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was never used (verified by eyeballing `git log -p` all the way down), we don't seem to know what it's for, and it has no counterpart in the structs.
This is in preparation for moving to `controller-gen`, which is somewhat opinionated in that it does not allow us to pick the exact file names. I guess we do not really care what these are called anyway - the only place where these names show up is this integration test.
Also add go-bindata to the `generate` target, and a README.
They are the authoritative *source* now. Keep the test around as a way of making sure the file generated by go-bindata is up-to-date.
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
|
@porridge this seems backwards... but I'm anxious to see the end result. The CRD files in the folders were suppose to be removed. There were issues blocking us when init was added in... but I think those do not exist any more. This generated file keeps unexpectedly showing changes in the generated go file. :( |
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Remove the unused crdVersion from CRD. It was never used (verified by eyeballing `git log -p` all the way down), we don't seem to know what it's for, and it has no counterpart in the structs. * Rename the CRD files. This is in preparation for moving to `controller-gen`, which is somewhat opinionated in that it does not allow us to pick the exact file names. I guess we do not really care what these are called anyway - the only place where these names show up is this integration test. * goimports * Use go-bindata to embed YAML files with CRDs. Also add go-bindata to the `generate` target, and a README. * Remove option to write manifests from test. They are the authoritative *source* now. Keep the test around as a way of making sure the file generated by go-bindata is up-to-date. * Update README. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is the first big step towards #862.
It temporarily makes YAML files that reside in
config/crdsthe authoritative source for the KUDO CRDs. At the same time it drops the duplicate definition in thekudoinitpackage. Note that there is no user visible change (none of the golden files are updated).The next step to follow soon will be to make these YAML files auto-generated as well, by generating them from the structs in the
apissub-package, completing the journey to a single human-edited source of truth.Since these files are are the authoritative source now, we remove the option of auto-updating them in the integration test. However we keep the test around as a way of making sure the file generated by
go-bindatainmake generateis up-to-date.