Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 1207 (bug) and Regen code (to fix imports) #1229

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Dec 27, 2019

What this PR does / why we need it:
#1207 broken code gen and needs to be reverted... and likely to be refactored for future inclusion. Also Import clean up hit a bunch of generated classes which is inappropriate and is fixed with this PR.

Fixes #1218

@kensipe kensipe merged commit 854feb2 into master Dec 27, 2019
@kensipe kensipe deleted the ken/refactor-revert branch December 27, 2019 17:23
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
* Revert "Refactored instance validation webhook (#1207)"

This reverts commit 366222d.

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Generation is not working
1 participant