Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding code gen to CI build #1231

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Adding code gen to CI build #1231

merged 1 commit into from
Dec 30, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Dec 27, 2019 •
edited

It is necessary for code gen to be apart of the build process to ensure that code is clean...
Personally I would prefer we do NOT check in generated code.

Signed-off-by: Ken Sipe kensipe@gmail.com

@kensipe
adding code gen to ci build
3e45c1f 
Signed-off-by: Ken Sipe <kensipe@gmail.com>

move to static-check workflow

Signed-off-by: Ken Sipe <kensipe@gmail.com>

simple add code gen before lint

Signed-off-by: Ken Sipe <kensipe@gmail.com>
@gerred
Copy link
Member

gerred commented Dec 28, 2019

I go back and forth on this - IMO it's not the same as checking in vendored dependencies (although we used to do that with Go...), I'm not yet convinced that Kubernetes codegen is completely deterministic. On the other hand, I wouldn't mind not having commits that are just updating codegen.

Before we remove generated files from source, let's ensure that fresh clones are completely deterministic and we can "own" that toolset. Our codegen is hacky enough as is, but at least someone can usually clone and immediately go build the source.

@kensipe
Copy link
Member Author

kensipe commented Dec 30, 2019

agreed!

@kensipe kensipe merged commit 6e29e32 into master Dec 30, 2019
@kensipe kensipe deleted the ken/adding-test-2-ci branch December 30, 2019 03:46
@alenkacz
Copy link
Contributor

I actually disagree with this, I think the generated code should be checked in and people should not be force to generate before they can compile. Now if we run generate as part of CI we will never know that we have checked in all the generated code 🤷‍♀ Not sure what is this improving and why we merged it on the weekend (was there a rush?)

@alenkacz alenkacz mentioned this pull request Dec 31, 2019
Merged
@zen-dog
Copy link
Contributor

zen-dog commented Dec 31, 2019

I think the generated code should be checked in

I agree, codegen seems stable enough and the whole practice of generating everything locally predates modern languages, environments, and requirements.

ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
@kensipe @ANeumann82
adding code gen to ci build (#1231)
081181c 
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zen-dog zen-dog zen-dog approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@nfnt nfnt Awaiting requested review from nfnt nfnt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kensipe @gerred @alenkacz @zen-dog