Reintroduce 366222d (#1207) #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: existing `Validator` interface was removed, we're now using the underlying `http.Handler` interface to register webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook) (cherry picked from commit 366222d)
zen-dog
commented
Dec 28, 2019
| ) | ||
|
|
||
| // this forces the instance type to implement Validator interface, we'll get compile time error if it's not true anymore | ||
| var _ kudo.Validator = &Instance{} | ||
| // +k8s:deepcopy-gen=false |
There was a problem hiding this comment.
This is the actual change
kensipe
approved these changes
Dec 30, 2019
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Refactored instance validation webhook (#1207) Summary: existing `Validator` interface was removed, we're now using the underlying `http.Handler` interface to register webhooks. This reduces glue code and prepares the foundation for upcoming KEP-20 admission webhook which will use the same interface (but will be a mutating instead of validating webhook) (cherry picked from commit 366222d) * Reintroduce 366222d (#1207) Additionally: - excluded `instance_validator.go` from code generation - and fixed an erroneous client import Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally:
instance_validator.gofrom code generation