need to lock in version of generators #1236
Conversation
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
alenkacz,
gerred,
nfnt and
zen-dog
as code owners
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
| @@ -96,7 +96,7 @@ func configCrdsKudoDev_instancesYaml() (*asset, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| info := bindataFileInfo{name: "config/crds/kudo.dev_instances.yaml", size: 1040, mode: os.FileMode(420), modTime: time.Unix(1576836957, 0)} | |||
| info := bindataFileInfo{name: "config/crds/kudo.dev_instances.yaml", size: 0, mode: os.FileMode(0), modTime: time.Unix(0, 0)} | |||
There was a problem hiding this comment.
hmm I don't understand why were these changes required, can you explain please? Especially the mode and size...
There was a problem hiding this comment.
generated files should not change if the source does not change... the way bindata.go was originally implemented (which was recent) seems less mature than it should be in a number of ways. this pr resolves that. It isn't ok to have a dirty local repo with a make all or make generate. After a couple of weeks of wonder what was the issue... it was this.
it is the timestamp that is most offensive... it will change based on a new clone of the repo etc. There is a flag to "set" modtime however it doesn't take a 0 or it appears that 0 means generate it. we could set it to 1 but I thought that would be confusing. specifying "no metadata" zeros out modtime... and everything else. It isn't particular useful information for our context... and in most likely case, it was accidental... meaning it wasn't a decision... it was the default behavior.
There was a problem hiding this comment.
oh I see, so the key is -nometadata. Yeah I did not get that part. Thanks for the explanation
There was a problem hiding this comment.
thx, for the explanation, @kensipe , I was wondering the same thing as Alena
| @@ -85,9 +85,9 @@ deploy-clean: | |||
| # Generate code | |||
| generate: | |||
| ifeq (, $(shell which go-bindata)) | |||
| go get github.com/go-bindata/go-bindata/go-bindata | |||
| go get github.com/go-bindata/go-bindata/go-bindata@v3.1.2 | |||
| @@ -96,7 +96,7 @@ func configCrdsKudoDev_instancesYaml() (*asset, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| info := bindataFileInfo{name: "config/crds/kudo.dev_instances.yaml", size: 1040, mode: os.FileMode(420), modTime: time.Unix(1576836957, 0)} | |||
| info := bindataFileInfo{name: "config/crds/kudo.dev_instances.yaml", size: 0, mode: os.FileMode(0), modTime: time.Unix(0, 0)} | |||
There was a problem hiding this comment.
oh I see, so the key is -nometadata. Yeah I did not get that part. Thanks for the explanation
* Locked version go-bindata tool to specific version * turned off metadata for generated `bindata.go` file Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Ken Sipe kensipe@gmail.com
Follow up to #1211
It is not OK to not lock in the version of the build tool chain.
Also the file gen is out of date :(